On 9/11/22 08:03, Francois Romieu wrote:
Albert Zhou <albert.zhou.50@xxxxxxxxx> :This patch integrates the version-two r8152 drivers from Realtek into the kernel. I am new to kernel development, so apologies if I make newbie mistakes.While it makes sense to minimize differences betwenn Realtek's in-house driver and kernel r8152 driver, it does not mean that the out-of-tree driver is suitable for a straight kernel inclusion. If you want things to move forward in a not too painful way, you should split the more than 650 ko patch into smaller, more focused patches (huge patches also makes bisection mildly effective btw). In its current form, the submission is imho a bit abrasive to review.
Hi Francois, Thanks for the feedback. As I was not involved in the development, it will be difficult for me to achieve this. I will try contact the developers at Realtek to see if they can assist. I was under the false impression, that indeed the Realtek driver could simply be included in the kernel. But now I see that is not the case. Best, Albert Zhou
[...]Albert Zhou (5): net: move back netif_set_gso_max helpers r8152: update to version twoThis code misuses mutex in {read, write}_mii_word. It includes code and data that should be moved to firmware files.r8152: remove backwards compatibilityBackwards compatibility code should had been avoided in the first place. [...]r8152: remove redundant codeSame thing.
Attachment:
OpenPGP_0x218FE344C5A6867D.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
