On 9/11/22 04:28, Greg KH wrote:
// SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2014 Realtek Semiconductor Corp. All rights reserved. + * Copyright (c) 2021 Realtek Semiconductor Corp. All rights reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation.To start with, this is not correct. Don't add back license boiler-plate code.
Hi Greg, My apologies, I was unaware of this. This can be easily removed.
And you just changed the copyright notice incorrectly, that is not ok.
When I replaced the version-one code with the version-two code, I assumed the authors' copyright would be correct. What is the correct copyright notice?
+ * + * This product is covered by one or more of the following patents: + * US6,570,884, US6,115,776, and US6,327,625.Oh wow. That's playing with fire...
Do you believe this prohibits the code from being in the kernel? I had assumed these refer to the hardware, the ethernet adapter, since the code is covered by GPLv2.
thanks, greg k-h
Attachment:
OpenPGP_0x218FE344C5A6867D.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
