Albert Zhou <albert.zhou.50@xxxxxxxxx> :
> This patch integrates the version-two r8152 drivers from Realtek into
> the kernel. I am new to kernel development, so apologies if I make
> newbie mistakes.
While it makes sense to minimize differences betwenn Realtek's in-house
driver and kernel r8152 driver, it does not mean that the out-of-tree
driver is suitable for a straight kernel inclusion.
If you want things to move forward in a not too painful way, you should
split the more than 650 ko patch into smaller, more focused patches
(huge patches also makes bisection mildly effective btw).
In its current form, the submission is imho a bit abrasive to review.
[...]
> Albert Zhou (5):
> net: move back netif_set_gso_max helpers
> r8152: update to version two
This code misuses mutex in {read, write}_mii_word.
It includes code and data that should be moved to firmware files.
> r8152: remove backwards compatibility
Backwards compatibility code should had been avoided in the first
place.
[...]
> r8152: remove redundant code
Same thing.
--
Ueimor
