Re: [PATCH] cp210x: set drt/rts lines when port opens

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I'm wondering, if this bug only occurs on the cp210x driver/hardware  
> why not just fix it in the cp210x_open() ?
> If it occurs in  other drivers then yes, its best to avoid the 
> duplicated code.

The dtr_rts and carrier methods are called in the right places, at the
right times (hopefully now anyway) from a single place. The idea of that
is to remove lots of often incorrect driver specific code and keep it
under control in one location.

the tty_port.c patch is a real bug that is shared across drivers so needs
fixing there. The other bit makes cp210x use the new framework and in
doing so makes it properly standards compliant as well.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux