Karl Hiramoto wrote:
Ok with both patches everything works as before 9a68e39d4a From
(2.6.15 <= kernels <= 2.6.30.x)
tty_port: If we are opened non blocking we still need to raise the
carrier
From: Alan Cox <alan@xxxxxxxxxxxxxxx>
The tty_port code inherited a bug common to various drivers it was based
upon. If the tty is opened O_NONBLOCK we do not wait for the carrier
to be
raised but we must still raise our modem lines if appropriate.
(There is a second question here about whether we should do so if
CLOCAL is
set but that can wait)
I'm wondering, if this bug only occurs on the cp210x driver/hardware
why not just fix it in the cp210x_open() ?
If it occurs in other drivers then yes, its best to avoid the
duplicated code.
Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
Reported-by: Karl Hiramoto <karl@xxxxxxxxxxxx>
Tested-by: Karl Hiramoto <karl@xxxxxxxxxxxx>
---
drivers/char/tty_port.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/char/tty_port.c b/drivers/char/tty_port.c
index 8e85657..ed05d2a 100644
--- a/drivers/char/tty_port.c
+++ b/drivers/char/tty_port.c
@@ -243,6 +243,9 @@ int tty_port_block_til_ready(struct tty_port *port,
the port has just hung up or is in another error state */
if ((filp->f_flags & O_NONBLOCK) ||
(tty->flags & (1 << TTY_IO_ERROR))) {
+ /* Indicate we are open */
+ if (tty->termios->c_cflag & CBAUD)
+ tty_port_raise_dtr_rts(port);
port->flags |= ASYNC_NORMAL_ACTIVE;
return 0;
}
I haven't seen any movement on this patch in a week, and it's not in
linus's tree yet. Hoping it doesn't get forgotten.
I've been using this patch on top of 2.6.31.4 along the patch from Alan
earlier http://www.spinics.net/lists/linux-usb/msg23253.html or
http://marc.info/?l=linux-usb&m=125546959814893&w=2
If you want i can resend the patches in a new clean email.
Thanks.
--
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
