Re: skel_read really sucks royally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-09-09 at 06:51 -0700, Greg KH wrote:
> On Wed, Sep 09, 2009 at 02:16:23PM +0200, Oliver Neukum wrote:
> > The read code path of the skeleton driver really sucks
> > -skel_read works only for devices which always send data
> > -the timeout comes out of thin air
> > -it blocks signals for the duration of the timeout
> > -it disallows nonblocking IO by design
> Yeah, all of that is true.
> > This patch fixes it by using a real urb, a completion and interruptible waits.
> > What do you think?
> It makes it more complex, but more "real-world" like.
> Thanks, I'll queue it up.
> greg k-h

Hi all,
I have been using the usb-skeleton driver as a starting
point for a driver for a device we are developing.

Would it be possible to leave it alone and to add a new
usb-skel2 driver that has all the complex bits?

Tony Olech
Elan Digital Systems Limited

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux