On Wed, Sep 09, 2009 at 02:16:23PM +0200, Oliver Neukum wrote: > The read code path of the skeleton driver really sucks > > -skel_read works only for devices which always send data > -the timeout comes out of thin air > -it blocks signals for the duration of the timeout > -it disallows nonblocking IO by design Yeah, all of that is true. > This patch fixes it by using a real urb, a completion and interruptible waits. > What do you think? It makes it more complex, but more "real-world" like. Thanks, I'll queue it up. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
