Re: u_serial ring buffer bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 27 August 2009, George Spelvin wrote:
> > This makes more than one patch.  I count:
> >
> > - using buf size as a compile time constant
> >
> > - changing the index scheme
> >
> > - a few gratuitous changes like
> >	unsigned len;
> >	...
> >	len = ...;
> >
> >   becoming
> >	unsigned len = ...;
> 
> Really, I was just doing #2.  #1 I did because it was less work
> than any alternative scheme for guaranteeing that that buf_size
> was always a power of two.

And #2 is what needs careful review, which is hard
because of all the rest.  :)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux