Re: [PATCH 6/6] USB: gadget/u_serial.c: draw attention to some unnecessary code.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 27 August 2009, George Spelvin wrote:
> Maybe someone can tell me if it should be deleted?

If it's not needed, yes; but this can be part of the
patch #4 updating a call site ... 

> ---
>  drivers/usb/gadget/u_serial.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> index 57005b0..701e35d 100644
> --- a/drivers/usb/gadget/u_serial.c
> +++ b/drivers/usb/gadget/u_serial.c
> @@ -216,7 +216,7 @@ gs_buf_put(struct gs_buf *gb, const char *buf, unsigned count)
>  	if (count > len)
>  		count = len;
>  
> -	if (count == 0)
> +	if (count == 0)		/* This short-cut isn't actually necessary */
>  		return 0;
>  
>  	len = WRITE_BUF_SIZE - put_pos;
> @@ -251,7 +251,7 @@ gs_buf_get(struct gs_buf *gb, char *buf, unsigned count)
>  	if (count > len)
>  		count = len;
>  
> -	if (count == 0)
> +	if (count == 0)		/* This short-cut isn't actually necessary */
>  		return 0;
>  
>  	len = WRITE_BUF_SIZE - get_pos;
> -- 
> 1.6.3.3
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux