On Tue, Aug 24, 2021 at 06:49:42PM +0200, Samuel Čavoj wrote:
> On 24.08.2021 13:24, Heikki Krogerus wrote:
> > On Mon, Aug 23, 2021 at 08:06:26PM +0200, Samuel Čavoj wrote:
> > > Hello,
> > >
> > > The driver times out talking to the PPM (the message pops up 60 seconds
> > > after loading the module, the timeout in ucsi_acpi_sync_write).
> > > The command which times out is the first one after resetting the PPM in
> > > ucsi_init, enabling basic notifications.
> > >
> > > The laptop in question is an ASUS UM325U, with the AMD Ryzen 5700U SoC.
> > >
> > > The ACPI description of the USBC000 device looks reasonable to my eyes,
> > > but I am not an expert. The _DSM Method copies the UCSI OpRegion to (or
> > > from) EC memory. I can provide a dump if needed.
> > >
> > > I am looking for guidance on how to proceed, I am not too familiar with
> > > the UCSI other than peeking at the spec for a short while.
> > >
> > > Looking the error up online leads to various discussions usually ending
> > > with installing an nvidia driver, however mine does not have any
> > > dedicated GPU.
> >
> > Can you send full dmesg output, and acpidump:
> >
> > % dmesg > dmesg.dump
> > % acpidump -o acpi.dump
> >
> > If enabling the notifications fails, then I'm not sure the EC firmware
> > on this board actually supports UCSI. That would not be unheard-of
> > situation.
> >
> > thanks,
> >
> > --
> > heikki
>
> Hello,
>
> I've attached the respective dumps, I hope they arrive in one piece.
>
> I've tried poking at the firmware in Windows, using UcsiControl.exe.
>
> Running
>
> UcsiControl.exe Send 0 1
>
> times out after a couple seconds, I assume this is related. The command
> is supposed to reset the controller, but maybe it then runs some commands
> as well. Running
>
> UcsiControl.exe Send 0 6
>
> responds with a result instantly, supposedly this is the GetCapability
> command. I don't know how to interpret the results, but I can attach
> them if needed. The program is documented at [1].
>
> This leads me to think that the firmware does actually support it, but
> has some kind of problem.
The reset command does not generate command completion event in UCSI
(that's why we poll the responce separately in the driver, just like
the spec tells us to do). So that command timing out may be expected.
You said that enabling the notifications with Set Notifications Enable
fails, so can you try this:
UcsiControl.exe Send 0 00010005
thanks,
--
heikki
