Greg KH wrote: > On Fri, Aug 21, 2009 at 04:24:28PM +0100, David Vrabel wrote: >> Greg KH wrote: >>> On Fri, Aug 21, 2009 at 02:48:47PM +0000, David Vrabel wrote: >>>> Don't override bcdUSB in the device descriptor from user space. It's not >>>> necessarily a USB 2.0 device. >>> Hm, are you sure? >>> >>> Why is this part of a wireless usb patch queue? :) >> Wireless USB devcies have a different bcdUSB value (0x0250). > > That would have been good to add to the changelog comment :) > >>> And how would we now tell the host what the bcdUSB is? >> It's part of the device descriptor provided by the userspace application >> that is using gadgetfs. > > But will this now break existing stuff that was expecting the kernel to > override the value? Drop this patch then. gadgetfs will need to obtain the correct bcdUSB value from the UDCD. I don't have time to look at this at the moment. David -- David Vrabel, Senior Software Engineer, Drivers CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562 Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/ 'member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom' -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
