Alan Stern wrote: > On Fri, 21 Aug 2009, David Vrabel wrote: > >> Greg KH wrote: >>> On Fri, Aug 21, 2009 at 02:48:45PM +0000, David Vrabel wrote: >>>> The WHCI HCD will also support urbs with scatter-gather lists. Add a >>>> usb_bus field to indicated how many sg list elements are supported by >>>> the HCD. >>> That's nice. >>> >>>> Save space in struct urb by adding a URB_HAS_SG flag and reusing >>>> transfer_buffer to point to a struct sg_table. >>> That isn't nice. >> It's what Alan Stern asked for. >> >> http://marc.info/?l=linux-usb&m=123334494530421&w=2 > > True, but in the meantime I have changed my mind. Okay. I can respin the patch to keep struct urb the same. > There's an advantage > to always having a pointer to the data buffer available. This is > related to usbmon and those other changes in the DMA setup. What data buffer? There's nothing sensible you can point transfer_buffer or transfer_dma to so I don't see how it helps. usbmon is currently broken for urbs with sg lists. David -- David Vrabel, Senior Software Engineer, Drivers CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562 Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/ 'member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom' -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
