Re: [PATCH 05/11] usb: gadgetfs: don't override bcdUSB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 21 August 2009, David Vrabel wrote:
> Don't override bcdUSB in the device descriptor from user space.  It's not
> necessarily a USB 2.0 device.
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxx>
> ---
>  drivers/usb/gadget/inode.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
> index 7d33f50..c31361d 100644
> --- a/drivers/usb/gadget/inode.c
> +++ b/drivers/usb/gadget/inode.c
> @@ -1905,8 +1905,6 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
>  			|| dev->dev->bDescriptorType != USB_DT_DEVICE
>  			|| dev->dev->bNumConfigurations != 1)
>  		goto fail;
> -	dev->dev->bNumConfigurations = 1;

That is not mentioned in $DESCRIPION either ...

> -	dev->dev->bcdUSB = cpu_to_le16 (0x0200);
>  
>  	/* triggers gadgetfs_bind(); then we can enumerate. */
>  	spin_unlock_irq (&dev->lock);
> -- 
> 1.6.3.3
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux