Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Monday, July 26, 2021 4:37 PM [...] > You also do other things, like renaming defines, which is not just > moving code around, right? Yes. You are right. [...] > I do not know, is it really easier to find things in 3 different files > instead of one? That's up to you, but you did not say why this change > is needed. We support a new chip or feature with a test driver. The test driver is similar with the upstream driver, except the method of the firmware. After we confirm that the test driver work fine, we compare the differences with the upstream driver and submit patches. And the code about firmware takes us more time to find out the differences. Therefore, I wish to move the part of the firmware out. I don't sure if it is acceptable for such patches. If it is unacceptable, I would abandon these patches. Best Regards, Hayes
