On Mon, Jul 26, 2021 at 12:01:09PM +0800, Hayes Wang wrote: > Rename r8152.c with r8152_main.c. Move some basic definitions from > r8152_main.c to r8152_basic.h. Move the relative code of firmware > from r8152_main.c to r8152_fw.c. Rename the definition of "EFUSE" > with "USB_EFUSE". That is a lot of different things all happening in one commit, why? Please break this up into "one patch per change" and submit it that way. But the real question is why break this file up in the first place? What is wrong with the way it is today? What future changes require this file to be in smaller pieces? If none, why make this? If there are future changes, then please submit this change when you submit those, as that would show a real need. thanks, greg k-h
