On Mon, Jul 26, 2021 at 08:26:00AM +0000, Hayes Wang wrote: > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > > Sent: Monday, July 26, 2021 3:37 PM > [...] > > That is a lot of different things all happening in one commit, why? > > I plan to separate the file into two files. And > I find I need an additional header file for it, so > The patch includes adding that header file. You also do other things, like renaming defines, which is not just moving code around, right? > > Please break this up into "one patch per change" and submit it that way. > > > > But the real question is why break this file up in the first place? > > What is wrong with the way it is today? What future changes require > > this file to be in smaller pieces? If none, why make this? If there > > are future changes, then please submit this change when you submit > > those, as that would show a real need. > > The purpose is let me easy to maintain the driver. > The code is larger and larger. And I find that the > r8169.c has been separated into three files. > Therefore, I think maybe I could split the driver > into small parts like r8169. Then, the code wouldn't > be complex. I do not know, is it really easier to find things in 3 different files instead of one? That's up to you, but you did not say why this change is needed. thanks, greg k-h
