On Tue, Aug 18, 2009 at 09:27:36AM +0200, Daniel Mack wrote: > On Mon, Aug 17, 2009 at 01:53:32PM -0700, Greg KH wrote: > > On Fri, Aug 14, 2009 at 08:04:46AM +0200, Daniel Mack wrote: > > > > > > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > > > index 19cb7d5..3ecf7e6 100644 > > > --- a/drivers/usb/Makefile > > > +++ b/drivers/usb/Makefile > > > @@ -42,3 +42,5 @@ obj-$(CONFIG_USB) += misc/ > > > > > > obj-$(CONFIG_USB_ATM) += atm/ > > > obj-$(CONFIG_USB_SPEEDTOUCH) += atm/ > > > + > > > +obj-$(CONFIG_USB_ISP1504) += otg/ > > > > This change is not needed if your Kconfig dependancies are correct. > > > > > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig > > > index aa884d0..c393aba 100644 > > > --- a/drivers/usb/otg/Kconfig > > > +++ b/drivers/usb/otg/Kconfig > > > @@ -41,6 +41,12 @@ config ISP1301_OMAP > > > This driver can also be built as a module. If so, the module > > > will be called isp1301_omap. > > > > > > +config USB_ISP1504 > > > + bool "NXP ISP1504 Transceiver Driver" > > > + help > > > + Enable this to support the NXP ISP1504 USB OTG transceiver which > > > + are likely found on embedded boards. > > > + > > > > Which they don't seem to be :( > > > > You need to depend on the OTG core here, right? > > Actually I don't, that dependency wasn't added on purpose. The code from > otg.c is unneeded in my case. I saw no need to add to the text size. > > > And why can't you build this driver as a module? > > There is no framework in the code currently for that. So no, I didn't > consider that. Couldn't that be fixed up later if anyone needs the > driver as a module? Well, no distro wants to built it into the kernel image as 99% of their users would not use it, right? So please resolve this. > > And do you really want this building on x86 architectures? > > Why not? I see no reason to forbid that? Is this hardware availble on x86 platforms today? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
