On Fri, Aug 14, 2009 at 08:04:46AM +0200, Daniel Mack wrote: > On Fri, Aug 14, 2009 at 07:58:23AM +0200, Daniel Mack wrote: > > diff --git a/include/linux/usb/isp1504.h b/include/linux/usb/isp1504.h > > new file mode 100644 > > index 0000000..2c14a18 > > --- /dev/null > > +++ b/include/linux/usb/isp1504.h > > @@ -0,0 +1,6 @@ > > +#ifndef __LINUX_USB_ISP1504_XCVR_H > > +#define __LINUX_USB_ISP1504_XCVR_H > > + > > +extern struct otg_transceiver *otg_isp1504_create(struct otg_io_access_ops *ops); > > + > > +#endif /* __LINUX_USB_ISP1504_XCVR_H */ > > Ah, sorry - as Valentin pointed out, that 'extern' shouldn't be there. > Take the patch below instead please. > > Daniel > > > >From 382c09a6fbce8272d71fa7f62d13fc7f4b1a5b35 Mon Sep 17 00:00:00 2001 > From: Daniel Mack <daniel@xxxxxxxx> > Date: Thu, 25 Jun 2009 13:33:48 +0200 > Subject: [PATCH] USB OTG: Add driver for NXP's ISP1504 transceiver > > This adds a minimal driver for NXP's ISP1504 transceivers, using the OTG > framework functions recently introduced. > > Signed-off-by: Daniel Mack <daniel@xxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxx> > Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > --- > drivers/usb/Makefile | 2 + > drivers/usb/otg/Kconfig | 6 ++ > drivers/usb/otg/Makefile | 1 + > drivers/usb/otg/isp1504.c | 108 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/usb/isp1504.h | 6 ++ > 5 files changed, 123 insertions(+), 0 deletions(-) > create mode 100644 drivers/usb/otg/isp1504.c > create mode 100644 include/linux/usb/isp1504.h > > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > index 19cb7d5..3ecf7e6 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -42,3 +42,5 @@ obj-$(CONFIG_USB) += misc/ > > obj-$(CONFIG_USB_ATM) += atm/ > obj-$(CONFIG_USB_SPEEDTOUCH) += atm/ > + > +obj-$(CONFIG_USB_ISP1504) += otg/ This change is not needed if your Kconfig dependancies are correct. > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig > index aa884d0..c393aba 100644 > --- a/drivers/usb/otg/Kconfig > +++ b/drivers/usb/otg/Kconfig > @@ -41,6 +41,12 @@ config ISP1301_OMAP > This driver can also be built as a module. If so, the module > will be called isp1301_omap. > > +config USB_ISP1504 > + bool "NXP ISP1504 Transceiver Driver" > + help > + Enable this to support the NXP ISP1504 USB OTG transceiver which > + are likely found on embedded boards. > + Which they don't seem to be :( You need to depend on the OTG core here, right? And why can't you build this driver as a module? And do you really want this building on x86 architectures? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
