Re: [PATCH 1/3] usb: phy: phy-mxs-usb: Use of_device_get_match_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20-11-24 22:21:40, Fabio Estevam wrote:
> Hi Peter,
> 
> On Tue, Nov 24, 2020 at 10:15 PM Peter Chen <peter.chen@xxxxxxx> wrote:
> 
> > > -     mxs_phy->data = of_id->data;
> > > +     mxs_phy->data = of_device_get_match_data(&pdev->dev);
> >
> > You may forget the error handling for it, eg, -ENODEV.
> 
> How can this happen?

When adding the new SoCs, the new compatible is added at dts, but forget
adding at device driver's of_device_id table?

-- 

Thanks,
Peter Chen



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux