On 20-11-24 22:21:40, Fabio Estevam wrote: > Hi Peter, > > On Tue, Nov 24, 2020 at 10:15 PM Peter Chen <peter.chen@xxxxxxx> wrote: > > > > - mxs_phy->data = of_id->data; > > > + mxs_phy->data = of_device_get_match_data(&pdev->dev); > > > > You may forget the error handling for it, eg, -ENODEV. > > How can this happen? When adding the new SoCs, the new compatible is added at dts, but forget adding at device driver's of_device_id table? -- Thanks, Peter Chen