On 20-11-24 13:39:10, Fabio Estevam wrote: > The retrieval of driver data via of_device_get_match_data() can make > the code simpler. > > Use of_device_get_match_data() to simplify the code. > > Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> > --- > drivers/usb/phy/phy-mxs-usb.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c > index 67b39dc62b37..8a262c5a0408 100644 > --- a/drivers/usb/phy/phy-mxs-usb.c > +++ b/drivers/usb/phy/phy-mxs-usb.c > @@ -714,14 +714,9 @@ static int mxs_phy_probe(struct platform_device *pdev) > struct clk *clk; > struct mxs_phy *mxs_phy; > int ret; > - const struct of_device_id *of_id; > struct device_node *np = pdev->dev.of_node; > u32 val; > > - of_id = of_match_device(mxs_phy_dt_ids, &pdev->dev); > - if (!of_id) > - return -ENODEV; > - > base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > @@ -797,7 +792,7 @@ static int mxs_phy_probe(struct platform_device *pdev) > mxs_phy->phy.charger_detect = mxs_phy_charger_detect; > > mxs_phy->clk = clk; > - mxs_phy->data = of_id->data; > + mxs_phy->data = of_device_get_match_data(&pdev->dev); You may forget the error handling for it, eg, -ENODEV. Peter > > platform_set_drvdata(pdev, mxs_phy); > > -- > 2.17.1 > -- Thanks, Peter Chen
