Hi Peter, On Tue, Nov 24, 2020 at 10:15 PM Peter Chen <peter.chen@xxxxxxx> wrote: > > - mxs_phy->data = of_id->data; > > + mxs_phy->data = of_device_get_match_data(&pdev->dev); > > You may forget the error handling for it, eg, -ENODEV. How can this happen?