On Fri, Jul 03, 2009 at 05:37:47PM +0900, Paul Mundt wrote: > On Fri, Jul 03, 2009 at 05:34:41PM +0900, Yoshihiro Shimoda wrote: > > Yoshihiro Shimoda wrote: > > > Magnus Damm wrote: > > >> From: Magnus Damm <damm@xxxxxxxxxx> > > >> > > >> This patch updates the m66592-udc buffer management code. > > >> > > >> Use fixed buffers for bulk and isochronous pipes, also make > > >> sure to handle the isochronous-as-bulk case. With fixed buffers > > >> there is no need to keep track of used buffers with bi_bufnum. > > >> > > >> Also, this fixes a potential buffer offset problem where the > > >> base offset incorrectly varies with the number of pipes used. > > >> > > >> With this patch applied it is possible to use m66592-udc for > > >> both Ethernet and Serial using CONFIG_USB_CDC_COMPOSITE. > > >> > > >> Signed-off-by: Magnus Damm <damm@xxxxxxxxxx> > > > > > > Thank you for your patch. > > > I also thought that this management method was good. > > > In addition, thank you for finding a potential problem. > > > I tested this patch and confirmed it is working. > > > > I'm sorry. I forgot to write the Acked-by: > > > > Acked-by: Yoshihiro Shimoda <shimoda.yoshihiro@xxxxxxxxxxx> > > > Greg, any preferences? I was planning on just rolling this in to my > 2.6.32 queue unless you have any objections. No objection from me, please do so. Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html