On Wed, Jul 01, 2020 at 08:45:19AM +0000, Peter Chen wrote:
>> drivers/usb/chipidea/udc.c >> 1634: ret = hw_read(ci, OP_FRINDEX, 0x3fff); > >Hi Michael, > >I can't find the above code for chipidea, where did you get? I was greping my usb-wip stack where I have an extra Patch for the get_frame callback implementation of the chipidea/udc.c. I think I will have to post it.Welcome to that.>The frame index value register is a standard EHCI register, but for >UDC, it is not a common register. UDC design is varied for vendors. Good to know. Is there any measure to find out if it is there? I would add that limitation to the above mentioned patch.Sorry, I can't get your point. My point was 0x3fff is the mask for Frame Index Register for standard EHCI controller, but this value may not the same meaning for other controllers. So, I suggest only defining for dwc3 in your patch.
Yes I got that now, I somehow missread it for being also not common in chipidea udc versions. Now that it is clear, I can post the patch. Thanks, Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
