> >> drivers/usb/chipidea/udc.c > >> 1634: ret = hw_read(ci, OP_FRINDEX, 0x3fff); > > > >Hi Michael, > > > >I can't find the above code for chipidea, where did you get? > > I was greping my usb-wip stack where I have an extra Patch for the get_frame > callback implementation of the chipidea/udc.c. I think I will have to post it. > Welcome to that. > >The frame index value register is a standard EHCI register, but for > >UDC, it is not a common register. UDC design is varied for vendors. > > Good to know. Is there any measure to find out if it is there? I would add that > limitation to the above mentioned patch. > Sorry, I can't get your point. My point was 0x3fff is the mask for Frame Index Register for standard EHCI controller, but this value may not the same meaning for other controllers. So, I suggest only defining for dwc3 in your patch. Peter > Thanks, > Michael > > >> > >> drivers/usb/dwc3/gadget.c > >> 1406: test_frame_number = dep->frame_number & 0x3fff; > >> 1453: dep->frame_number &= 0x3fff; > >> > >> drivers/usb/host/ohci-hcd.c > >> 557: ohci->fminterval = val & 0x3fff; > >> > >> drivers/usb/host/xhci-ring.c > >> 3980: start_frame &= 0x3fff; > >> > >> drivers/usb/host/ohci-dbg.c > >> 635: rdata & 0x3fff); > >> 641: rdata & 0x3fff); > >> 647: rdata & 0x3fff); > >> > >> drivers/usb/host/u132-hcd.c > >> 1535: ((9 * fi) / 10) & 0x3fff); > >> 1605: u132->hc_fminterval = temp & 0x3fff; > >> > >> drivers/usb/host/ohci.h > >> 701: ohci_writel (ohci, ((9 * fi) / 10) & 0x3fff, > >> > >> I could write a patch changing them all or at least make a common > >> gadget define. > >> > >> What could be a common place for that? > >> > >> On device level only it could be include/linux/usb/gadget.h On whole > >> usb level this could be include/uapi/linux/usb/ch9.h > >> > >> Ideas? > >> > >> >For both patches in this series: > >> >Reviewed-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx> > >> > > >> >Thanks, > >> >Thinh > >> > >> Thanks! > >> Michael > >> > >> -- > >> Pengutronix e.K. | | > >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | > >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
