Re: [Bugme-new] [Bug 13624] New: usb: wrong autosuspend initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote:
On Thu, 25 Jun 2009 16:50:51 -0400 (EDT)
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

THis patch disables autosuspend in the usbhid driver.  Apparently too
many people have bogus udev scripts that activate autosuspend for
mice which can't support it properly.

Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

---

Index: 2.6.30/drivers/hid/usbhid/hid-core.c
===================================================================
--- 2.6.30.orig/drivers/hid/usbhid/hid-core.c
+++ 2.6.30/drivers/hid/usbhid/hid-core.c
@@ -1377,7 +1377,8 @@ static struct usb_driver hid_driver = {
 	.pre_reset =	hid_pre_reset,
 	.post_reset =	hid_post_reset,
 	.id_table =	hid_usb_ids,
-	.supports_autosuspend = 1,
+/* Disable this until bogus udev scripts aren't so widespread */
+/*	.supports_autosuspend = 1,	*/
 };

mmmm..

a) we don't yet have enough data to know whether this is necessary

b) the patch doesn't provide us a way of ever fixing things up.  Is
there any way in which the kernel can detect the problem and then emit
a "hey, fix your junk" printk?


Right. Well then I guess I'll go tell laptop-mode to refrain from autosuspending my input devices...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux