Re: [Bugme-new] [Bug 13624] New: usb: wrong autosuspend initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Jun 2009, Andrew Morton wrote:

> We need to be practical here.  Look at the effects of each change and
> work out what we should do so as to produce the best result for real
> people using Linux in the real world.
> 
> I have in the past rejected outright bugfixes because fixing the bug
> could break existing userspace.  Such is life.
> 
> > I suggest that the bug reporter search for a udev rule under either 
> > /lib/udev or /etc/udev which writes "auto" to the mouse's power/level 
> > attribute.  Perhaps Marcus can tell us exactly where he found the bogus 
> > rule on his system.
> 
> Well that would help, and hopefully the number of people who are
> hitting this is small.
> 
> But if the problem turns out to be significantly widespread then sure,
> we may end up deciding to provide a workaround in the kernel.
> 
> For practical reasons.

All right, here is a practical patch disabling autosuspend support in 
usbhid.  I hope we don't have to apply it.

Alan Stern

-----------------------------------------------------------------------


THis patch disables autosuspend in the usbhid driver.  Apparently too
many people have bogus udev scripts that activate autosuspend for
mice which can't support it properly.

Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

---

Index: 2.6.30/drivers/hid/usbhid/hid-core.c
===================================================================
--- 2.6.30.orig/drivers/hid/usbhid/hid-core.c
+++ 2.6.30/drivers/hid/usbhid/hid-core.c
@@ -1377,7 +1377,8 @@ static struct usb_driver hid_driver = {
 	.pre_reset =	hid_pre_reset,
 	.post_reset =	hid_post_reset,
 	.id_table =	hid_usb_ids,
-	.supports_autosuspend = 1,
+/* Disable this until bogus udev scripts aren't so widespread */
+/*	.supports_autosuspend = 1,	*/
 };
 
 static const struct hid_device_id hid_usb_table[] = {

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux