On Wed 11 Mar 12:15 PDT 2020, Bryan O'Donoghue wrote: > This patch enables the primary and secondary USB controllers on the > qcs404-evb. > > Primary: > The primary USB controller has > > - One USB3 SS PHY using gpio-usb-conn > - One USB2 HS PHY in device mode only and no connector driver > associated. > > Secondary: > The second DWC3 controller which has one USB Hi-Speed PHY attached to it. > > Cc: Andy Gross <agross@xxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Tested-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> Hi Bryan, I dropped the role switching for now, did some testing and applied the series for v5.8. Let's follow up with a patch adding the role switching once the dwc3 discussion is sorted out. Thanks, Bjorn > --- > arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 40 ++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > index 44c7dda1e1fc..4dc3f45282fe 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > @@ -319,6 +319,46 @@ pinconf { > }; > }; > > +&usb2 { > + status = "okay"; > +}; > + > +&usb2_phy_sec { > + vdd-supply = <&vreg_l4_1p2>; > + vdda1p8-supply = <&vreg_l5_1p8>; > + vdda3p3-supply = <&vreg_l12_3p3>; > + status = "okay"; > +}; > + > +&usb3 { > + status = "okay"; > + dwc3@7580000 { > + usb-role-switch; > + usb_con: connector { > + compatible = "gpio-usb-b-connector"; > + label = "USB-C"; > + id-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; > + vbus-supply = <&usb3_vbus_reg>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb3_id_pin>, <&usb3_vbus_pin>; > + status = "okay"; > + }; > + }; > +}; > + > +&usb2_phy_prim { > + vdd-supply = <&vreg_l4_1p2>; > + vdda1p8-supply = <&vreg_l5_1p8>; > + vdda3p3-supply = <&vreg_l12_3p3>; > + status = "okay"; > +}; > + > +&usb3_phy { > + vdd-supply = <&vreg_l3_1p05>; > + vdda1p8-supply = <&vreg_l5_1p8>; > + status = "okay"; > +}; > + > &wifi { > status = "okay"; > vdd-0.8-cx-mx-supply = <&vreg_l2_1p275>; > -- > 2.25.1 >