On 20-02-28 08:48:56, Marco Felsch wrote: > Hi Peter, > > On 20-02-28 02:51, Peter Chen wrote: > > ... > > > > > CI_HDRC_TURN_VBUS_EARLY_ON is introduced by fixing a bug that some i.mx USB > > > > controllers PHY's power is sourced from VBUS, the PHY's power need to be on before > > > > touch some ehci registers, otherwise, the USB signal will be wrong at some low speed > > > > devices use case. So, this flag can't be deleted, it may cause regression. > > > > > > Pls check my archeological findings and again pls check my patches. I > > > deleted the flag because isn't required anymore afterwards. > > > > I have already checked your patch, your patch deletes CI_HDRC_TURN_VBUS_EARLY_ON > > quirk, and it may cause regression. > > Arg, sorry now I see what you mean. Thanks for your explanation :) > Since the 'struct ehci_ci_priv' contains now an enabled state we can > git rid of the flag. To get it right, the writing the ehci PORT_POWER > must be done before or after we enabled the VBUS? I'm asking because > we can drop the 1st patch of this series. Both are OK. -- Thanks, Peter Chen
