On 20-02-27 11:42:09, Marco Felsch wrote:
> Hi,
>
> the gpio-based port power is broken since commit [1,2]. I changed the
> core behaviour to to cleanup the code and avoid local workaround fixes.
Many i.mx series evk boards work well for gpio-based port power control,
what problem you have found, would you please list it detail?
Peter
>
> With this series and [3] I'am now able to disable the port completely
> after I disbaled the pm_qos_no_power_off flag.
>
> [1] 6adb9b7b5fb6 ("usb: chipidea: add a flag for turn on vbus early for host")
> [2] 659459174188 ("usb: chipidea: host: turn on vbus before add hcd if early vbus on is required")
> [3] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2020%2F2%2F27%2F198&data=02%7C01%7Cpeter.chen%40nxp.com%7Cc1b3094e826b49b572cb08d7bb71b6bc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637183969379126557&sdata=i7O7vBqiVCb2opVNva7ffxIdqFb%2BvGzV5Qsy5wwarbQ%3D&reserved=0
>
> Regards,
> Marco
>
> Marco Felsch (3):
> USB: ehci-hub: let port_power() override the ehci_port_power()
> Partially Revert "usb: chipidea: host: turn on vbus before add hcd if
> early vbus on is required"
> Revert "usb: chipidea: add a flag for turn on vbus early for host"
>
> drivers/usb/chipidea/ci_hdrc_imx.c | 10 ++--------
> drivers/usb/chipidea/host.c | 31 ++++++++++--------------------
> drivers/usb/host/ehci-hub.c | 6 +++---
> include/linux/usb/chipidea.h | 17 ++++++++--------
> 4 files changed, 23 insertions(+), 41 deletions(-)
>
> --
> 2.20.1
>
--
Thanks,
Peter Chen
