Hi Peter,
thanks for your fast reply :)
On 20-02-27 11:18, Peter Chen wrote:
> On 20-02-27 11:42:09, Marco Felsch wrote:
> > Hi,
> >
> > the gpio-based port power is broken since commit [1,2]. I changed the
> > core behaviour to to cleanup the code and avoid local workaround fixes.
>
> Many i.mx series evk boards work well for gpio-based port power control,
> what problem you have found, would you please list it detail?
Hm.. who could that work? I picked the important parts:
static int ehci_ci_portpower(struct usb_hcd *hcd, int portnum, bool enable)
{
...
if (priv->reg_vbus && enable != priv->enabled) {
...
if (enable)
ret = regulator_enable(priv->reg_vbus);
else
ret = regulator_disable(priv->reg_vbus);
...
}
...
}
static int host_start(struct ci_hdrc *ci)
{
...
priv->reg_vbus = NULL;
if (ci->platdata->reg_vbus && !ci_otg_is_fsm_mode(ci)) {
if (ci->platdata->flags & CI_HDRC_TURN_VBUS_EARLY_ON) {
ret = regulator_enable(ci->platdata->reg_vbus);
if (ret) {
dev_err(ci->dev,
"Failed to enable vbus regulator, ret=%d\n",
ret);
goto put_hcd;
}
} else {
priv->reg_vbus = ci->platdata->reg_vbus;
}
}
...
}
Note, I'm using a imx6q which has the CI_HDRC_TURN_VBUS_EARLY_ON set.
Regards,
Marco
> Peter
> >
> > With this series and [3] I'am now able to disable the port completely
> > after I disbaled the pm_qos_no_power_off flag.
> >
> > [1] 6adb9b7b5fb6 ("usb: chipidea: add a flag for turn on vbus early for host")
> > [2] 659459174188 ("usb: chipidea: host: turn on vbus before add hcd if early vbus on is required")
> > [3] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2020%2F2%2F27%2F198&data=02%7C01%7Cpeter.chen%40nxp.com%7Cc1b3094e826b49b572cb08d7bb71b6bc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637183969379126557&sdata=i7O7vBqiVCb2opVNva7ffxIdqFb%2BvGzV5Qsy5wwarbQ%3D&reserved=0
> >
> > Regards,
> > Marco
> >
> > Marco Felsch (3):
> > USB: ehci-hub: let port_power() override the ehci_port_power()
> > Partially Revert "usb: chipidea: host: turn on vbus before add hcd if
> > early vbus on is required"
> > Revert "usb: chipidea: add a flag for turn on vbus early for host"
> >
> > drivers/usb/chipidea/ci_hdrc_imx.c | 10 ++--------
> > drivers/usb/chipidea/host.c | 31 ++++++++++--------------------
> > drivers/usb/host/ehci-hub.c | 6 +++---
> > include/linux/usb/chipidea.h | 17 ++++++++--------
> > 4 files changed, 23 insertions(+), 41 deletions(-)
> >
> > --
> > 2.20.1
> >
>
> --
>
> Thanks,
> Peter Chen
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
