Re: [PATCH 2.6.30] USB: option.c: add Qualcomm/Option iCON 210 modem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kai,

> >> Add modem portion of USB device labeled:
> >> Model iCON 210, Qualcomm 3G HSDPA, designed in EU by Option
> >>
> >> Signed-off-by: Kai Engert<kaie@xxxxxxx>
> >> ---
> >>
> >> Resending to the correct mailing list (originally went to linux-kernel)
> >>
> >> Device starts in usb-storage mode (1e0e:f000) and requires the use of a tool like usb_modeswitch to switch it to modem mode (1e0e:9000).
> >> I'm not subscribed to the mailing list, please cc me on replies, thanks.
> >> Regards, Kai
> >>
> >> --- linux-2.6.30/drivers/usb/serial/option.c.preicon210	2009-06-12 08:11:37.000000000 +0200
> >> +++ linux-2.6.30/drivers/usb/serial/option.c	2009-06-12 08:11:39.000000000 +0200
> >> @@ -93,6 +93,9 @@
> >>    #define OPTION_PRODUCT_ETNA_KOI_MODEM		0x7100
> >>    #define OPTION_PRODUCT_GTM380_MODEM		0x7201
> >>
> >> +#define QUALCOMM_OPTION_VENDOR_ID		0x1e0e
> >> +#define QUALCOMM_OPTION_PRODUCT_ICON_210	0x9000
> >>      
> >
> > what non-sense is this. Either the vendor is Qualcomm or it is Option,
> > but not both.
> >    
> 
> I don't know the true vendor name. Both names are printed on the device:
> "Qualcomm ... designed by Option"
> 
> I concluded it's a collaboration. I couldn't find USB vendor ID 0x1E0E 
> anywhere else.
> 
> If you want me to pick one, I'd pick QUALCOMM.
> If I don't hear objections, I'll change it and send a new patch.

most likely it is neither of them. Qualcomm builds the UMTS chip that
Option uses and then these devices get branded.

What does lsusb -v or /proc/bus/usb/devices say about the vendor string.

I prefer we put a proper vendor in there and this USB vendor ids are
assigned it would be easy to find out who it belongs to.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux