On Thu, 11 Jun 2009 22:38:13 +0800
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> > /* PCI driver selection metadata; PCI hotplugging uses this */
> > @@ -418,6 +567,15 @@ static const struct pci_device_id pci_ids [] = { {
> > PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_EHCI, ~0),
> > .driver_data = (unsigned long) &ehci_pci_hc_driver,
> > },
> > + {
> > + /* handle MRST USB 2.0 EHCI controller */
> > + PCI_DEVICE_CLASS(0x0c2000, ~0),
> > + .driver_data = (unsigned long) &ehci_pci_hc_driver,
> > + },
> > + {
> > + PCI_DEVICE_CLASS(0x0c03fe, ~0),
> > + .driver_data = (unsigned long) &ehci_pci_hc_driver,
> > + },
> > { /* end: all zeroes */ }
> > };
>
> With all these changes and additions (including whole new probe and
> remove routines!), wouldn't it be cleaner simply to add a separate
> ehci-langwell-pci.c driver file?
>
That's good point, thanks. Please continue review the whole patch series, then
I could make comprehensive v2/v3 versions.
> Alan Stern
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
