Hi Lars, > Yes, USB_DEVICE_AND_INTERFACE_INFO is the one to use when all the > interfaces you add support for has identical class/subclass/protocol > attributes. > OK. I will change it to USB_DEVICE_AND_INTERFACE_INFO, and resend patch. Regards, Yoshiaki Okamoto ________________________________________ From: Lars Melin <larsm17@xxxxxxxxx> Sent: Friday, July 19, 2019 13:09 To: OKAMOTO Yoshiaki; johan@xxxxxxxxxx Cc: YAMAMOTO Hiroyuki; linux-usb@xxxxxxxxxxxxxxx Subject: Re: [PATCH v2] USB: serial: option: Add support for ZTE MF871A On 7/18/2019 21:46, OKAMOTO Yoshiaki wrote: > > Hi Lars, > >> Please do a full test of the interface attributes (Class/SubClass/Proto) >> whenever possible, this could be helpful in case the mfgr makes a device >> with different interface layout but re-uses an already used vid:pid. >> > What should we do specifically for "a full test of the interface attributes"? > > >> Both interfaces has attributes ff/00/00 so there is no reason for doing a less accurate test. >> > Forgive me if I’m wrong, did you say mean that we should use USB_DEVICE_AND_INTERFACE_INFO" instead of "USB_DEVICE_INTERFACE_CLASS" ? > > Regards, > Yoshiaki Okamoto > Yes, USB_DEVICE_AND_INTERFACE_INFO is the one to use when all the interfaces you add support for has identical class/subclass/protocol attributes. rgds /Lars
