RE: [PATCH 01/10] phy: renesas: rcar-gen3-usb2: Add uses_usb_x1 option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Tue, May 07, 2019, Geert Uytterhoeven wrote:
> > +       if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1"))
> > +               channel->uses_usb_x1 = true;
> > +
> 
> Perhaps this can be checked some other way (e.g. by checking for a non-
> zero
> clock rate of the USB_X1 clock referenced from DT), thus removing the need
> for
> adding a custom property?


Good point. I've done that for other drivers before and it worked well.

I'll take this out...one less property to set :)

Question: Since the driver depends on this, should I mention this in the
dt-bindings documentation ?

Thanks,
Chris




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux