Hi Chris,
On Tue, May 7, 2019 at 1:00 PM Chris Brandt <Chris.Brandt@xxxxxxxxxxx> wrote:
> On Tue, May 07, 2019, Geert Uytterhoeven wrote:
> > > + if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1"))
> > > + channel->uses_usb_x1 = true;
> > > +
> >
> > Perhaps this can be checked some other way (e.g. by checking for a non-
> > zero
> > clock rate of the USB_X1 clock referenced from DT), thus removing the need
> > for
> > adding a custom property?
>
> Good point. I've done that for other drivers before and it worked well.
>
> I'll take this out...one less property to set :)
>
> Question: Since the driver depends on this, should I mention this in the
> dt-bindings documentation ?
Yes, this should be described in the section about the clocks property.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
