On Mon, 4 May 2009, Kay Sievers wrote: > > If we are going to fulfill Dave's dream, this line: > > > >> + Â Â dev_set_name(&ep_dev->dev, "ep_%02x", endpoint->desc.bEndpointAddress); > > > > should instead become: > > > > Â Â Â Â if (usb_endpoint_xfer_control(&endpoint->desc)) > > Â Â Â Â Â Â Â Â dev_set_name(&ep_dev->dev, "ep%d", > > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â usb_endpoint_num(&endpoint->desc)); > > Â Â Â Â else > > Â Â Â Â Â Â Â Â dev_set_name(&ep_dev->dev, "ep%d-%s", > > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â usb_endpoint_num(&endpoint->desc), > > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â usb_endpoint_dir_in(&endpoint->desc) ? > > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "in" : "out"); > > > > And it might be good to encapsulate this mess in a separate function. > > Loks good, but is that subdir name used today? I thought the symlinks, > which are now directories again, have been there to keep some old > names? The existing links have names beginning with "ep_". You are removing them anyway (which might cause problems although I don't know of anybody using them). Regardless, there's no name clash because the new name begins with "ep%d". Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
