On Mon, May 4, 2009 at 21:34, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, 4 May 2009, Kay Sievers wrote: >> From: Kay Sievers <kay.sievers@xxxxxxxx> >> Subject: usb: convert endpoint devices to bus-less childs of the usb interface > This all looks okay to me. > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Nice. Thanks! > If we are going to fulfill Dave's dream, this line: > >> + dev_set_name(&ep_dev->dev, "ep_%02x", endpoint->desc.bEndpointAddress); > > should instead become: > > if (usb_endpoint_xfer_control(&endpoint->desc)) > dev_set_name(&ep_dev->dev, "ep%d", > usb_endpoint_num(&endpoint->desc)); > else > dev_set_name(&ep_dev->dev, "ep%d-%s", > usb_endpoint_num(&endpoint->desc), > usb_endpoint_dir_in(&endpoint->desc) ? > "in" : "out"); > > And it might be good to encapsulate this mess in a separate function. Loks good, but is that subdir name used today? I thought the symlinks, which are now directories again, have been there to keep some old names? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
