On Mon, 4 May 2009, Kay Sievers wrote: > Like this? Like spring cleaning? :) > > I left some of the earlier changes in, to make sure, that nothing goes > wrong, if the devices are eventually added to the usb bus (they would > just need unique names). > > Thanks, > Kay > > > From: Kay Sievers <kay.sievers@xxxxxxxx> > Subject: usb: convert endpoint devices to bus-less childs of the usb interface > > The endpoint devices look like simple attribute groups now, and no longer > like devices with a specific subsystem. They will also no longer emit uevents. > > It also removes the device node requests for endpoint devices, which are not > implemented for now. This all looks okay to me. Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> If we are going to fulfill Dave's dream, this line: > + dev_set_name(&ep_dev->dev, "ep_%02x", endpoint->desc.bEndpointAddress); should instead become: if (usb_endpoint_xfer_control(&endpoint->desc)) dev_set_name(&ep_dev->dev, "ep%d", usb_endpoint_num(&endpoint->desc)); else dev_set_name(&ep_dev->dev, "ep%d-%s", usb_endpoint_num(&endpoint->desc), usb_endpoint_dir_in(&endpoint->desc) ? "in" : "out"); And it might be good to encapsulate this mess in a separate function. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
