Hi Geeg, Finally.. I feel very close to submit patch.. I will look at "scripts/checkpatch.pl" Thanks! Charles Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> 於 2018年12月14日 週五 下午4:22寫道: > > On Fri, Dec 14, 2018 at 03:41:26PM +0800, Charles Yeh wrote: > > Hi Greg, > > The new patch file is attached: > > 0001-Add-Proliic-new-chip-PL2303TB-PL2303N-G.patch > > Please you kindly check... > > Much better, thanks. > > But no need to send this as an attachment, just send it all directly as > a single email. > > Also, please run your patch through scripts/checkpatch.pl before sending > it out. It will point out a number of coding style issues that the > patch has (look at the if() statement formatting) that needs to be > resolved before this can be accepted. > > Almost there! > > thanks, > > greg k-h