Hi Greg, The patch file: diffpl2303.patch is attached.. Please you kindly check... Thanks! Charles Charles Yeh <charlesyeh522@xxxxxxxxx> 於 2018年11月20日 週二 下午5:35寫道： > > Hi Greg, > Try again...no problem... > > make one patch for all of the files modified, <<---OK. > > proper changelog text and a signed-off-by line <<-- I will study > Documentation/SubmittingPatches again. > > use tabs, not spaces <<---OK. > > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> 於 2018年11月20日 週二 下午5:28寫道： > > > > On Tue, Nov 20, 2018 at 05:21:04PM +0800, Charles Yeh wrote: > > > Hi Johan, > > > After read Documentation\process\submitting-patches.rst, > > > I have write some describe in attach file : "diffpl2303c.patch" > > > "diffpl2303h.patch" > > > > > > If this file does not meet the file requirements, please let me > > > know how to do it. > > > > This is close, but not quite there yet. > > > > You need to make one patch for all of the files modified, look at all of > > the patches on the mailing list for examples of this. > > > > Also, you need a proper changelog text and a signed-off-by line, the > > file Documentation/SubmittingPatches in the kernel source tree will > > describe all of this and how to do it. > > > > And finally, your patch needs to properly use tabs, not spaces, look at > > the diff you generated for examples of how the lines do not align > > properly now. > > > > Can you try again please? > > > > thanks, > > > > greg k-h
Attachment:
diffpl2303.patch
Description: Binary data
