Re: [PATCH drivers\usb\serial\pl2303.c & pl2303.h] Prolific's PL2303G: new USB to UART chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 20, 2018 at 05:21:04PM +0800, Charles Yeh wrote:
> Hi Johan,
>       After read Documentation\process\submitting-patches.rst,
>       I have write some describe in attach file : "diffpl2303c.patch"
> "diffpl2303h.patch"
> 
>      If this file does not meet the file requirements, please let me
> know how to do it.

This is close, but not quite there yet.

You need to make one patch for all of the files modified, look at all of
the patches on the mailing list for examples of this.

Also, you need a proper changelog text and a signed-off-by line, the
file Documentation/SubmittingPatches in the kernel source tree will
describe all of this and how to do it.

And finally, your patch needs to properly use tabs, not spaces, look at
the diff you generated for examples of how the lines do not align
properly now.

Can you try again please?

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux