On 05.12.18 08:45, Schrempf Frieder wrote: > Hi Fabio, > > On 04.12.18 21:01, Fabio Estevam wrote: >> Hi Frieder, >> >> On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder >> <frieder.schrempf@xxxxxxxxxx> wrote: >> >>> There are many other optional properties for this driver and a lot of >>> them are not in the given example. Maybe we should just keep the >>> pinctrls for HSIC-mode out of the example, too? >> >> I am just trying to make life easier for those who want to use HSIC >> support with chipidea. >> >> Can we just add a real dts snippet example of your board into the >> binding document? > > Sure, here is what I have in my dts: > > &usbh2 { > pinctrl-names = "idle", "active"; > pinctrl-0 = <&pinctrl_usbh2_idle>; > pinctrl-1 = <&pinctrl_usbh2_active>; > status = "okay"; > #address-cells = <1>; > #size-cells = <0>; > > usbnet: smsc@1 { > compatible = "usb424,9730"; > reg = <1>; > }; > }; Or merged with the settings from imx6qdl.dtsi this will look like below. Maybe this is better as it is the complete node without depending on imx6qdl.dtsi: usbh2: usb@2184400 { compatible = "fsl,imx6q-usb", "fsl,imx27-usb"; reg = <0x02184400 0x200>; interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6QDL_CLK_USBOH3>; fsl,usbphy = <&usbphynop1>; fsl,usbmisc = <&usbmisc 2>; phy_type = "hsic"; dr_mode = "host"; ahb-burst-config = <0x0>; tx-burst-size-dword = <0x10>; rx-burst-size-dword = <0x10>; pinctrl-names = "idle", "active"; pinctrl-0 = <&pinctrl_usbh2_idle>; pinctrl-1 = <&pinctrl_usbh2_active>; #address-cells = <1>; #size-cells = <0>; usbnet: smsc@1 { compatible = "usb424,9730"; reg = <1>; }; }; > > @Peter: Can you add this as a second example to the binding documentation? > > Thanks, > Frieder >