Hello Peter, On Tue, Dec 04, 2018 at 06:19:11AM +0000, PETER CHEN wrote: > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > > index 80b4e4ef9b68..3dcfd0d97f94 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > > @@ -141,6 +141,8 @@ static struct imx_usbmisc_data > > *usbmisc_get_init_data(struct device *dev) > > } else if (of_find_property(np, "over-current-active-low", NULL)) { > > data->oc_pol_active_low = 1; > > data->oc_pol_configured = 1; > > + } else { > > + dev_warn(dev, "No over current polarity defined\n"); > > } > > If the platform doesn't support OC, the polarity setting is not needed. You could consider > getting polarity property only "disable-over-current" is not found at patch 1. Right, just fixed that up and will send out v3 in a moment. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |