RE: [PATCH v2 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 80b4e4ef9b68..3dcfd0d97f94 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -141,6 +141,8 @@ static struct imx_usbmisc_data
> *usbmisc_get_init_data(struct device *dev)
>  	} else if (of_find_property(np, "over-current-active-low", NULL)) {
>  		data->oc_pol_active_low = 1;
>  		data->oc_pol_configured = 1;
> +	} else {
> +		dev_warn(dev, "No over current polarity defined\n");
>  	}

If the platform doesn't support OC, the polarity setting is not needed. You could consider
getting polarity property only "disable-over-current" is not found at patch 1.

Peter





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux