Re: [PATCH] usb: ohci-sa1111: convert shutdown method to native device_driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Sep 2017, Russell King - ARM Linux wrote:

> On Tue, Sep 26, 2017 at 10:35:23AM -0400, Alan Stern wrote:
> > On Tue, 26 Sep 2017, Russell King wrote:
> > > Convert the shutdown method to use the device_driver shutdown function
> > > pointer rather than a private bus-type shutdown.  This is the only user
> > > for SA1111 bus types, so having the support code in the bus doesn't
> > > make any sense.

> > I have no objection to this patch.  But it leads me to wonder why you 
> > don't get rid of the SA1111 bus type entirely, rather than keeping it 
> > just for the sake of one driver?
> 
> I think you misunderstood the commit message.  This is the only user of
> the shutdown method for this bus type.  This is not the only user of
> this bus type - there are other drivers that use this bus type.

I see -- just a slight ambiguity in the description.  That's fine.

For all three of the ohci-sa1111 patches:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux