On Tue, Sep 26, 2017 at 11:35:32AM -0400, Alan Stern wrote: > On Tue, 26 Sep 2017, Russell King - ARM Linux wrote: > > > On Tue, Sep 26, 2017 at 10:35:23AM -0400, Alan Stern wrote: > > > On Tue, 26 Sep 2017, Russell King wrote: > > > > Convert the shutdown method to use the device_driver shutdown function > > > > pointer rather than a private bus-type shutdown. This is the only user > > > > for SA1111 bus types, so having the support code in the bus doesn't > > > > make any sense. > > > > I have no objection to this patch. But it leads me to wonder why you > > > don't get rid of the SA1111 bus type entirely, rather than keeping it > > > just for the sake of one driver? > > > > I think you misunderstood the commit message. This is the only user of > > the shutdown method for this bus type. This is not the only user of > > this bus type - there are other drivers that use this bus type. > > I see -- just a slight ambiguity in the description. That's fine. > > For all three of the ohci-sa1111 patches: > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Thanks, I've improved the commit message to clear up that misunderstanding. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
