Hi On Mon, Sep 25, 2017 at 6:09 PM, Grant Grundler <grundler@xxxxxxxxxxxx> wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: > Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler <grundler@xxxxxxxxxxxx> > --- > drivers/net/usb/cdc_ether.c | 8 ++++++++ > drivers/net/usb/r8152.c | 2 ++ > 2 files changed, 10 insertions(+) > > V2: add LINKSYS_VENDOR_ID to cdc_ether blacklist I understand that in v1 people pointed out that if we didn't add this to the cdc_ether blacklist that we might end up picking the wrong driver. ...but one thing concerns me: what happens if someone has the CDC_ETHER driver configured in their system but _not_ the R8152 driver? All of a sudden this USB Ethernet adapter which used to work fine with the CDC Ethernet driver will stop working. I know that for at least some of the adapters in the CDC Ethernet blacklist it was claimed that the CDC Ethernet support in the adapter was kinda broken anyway so the blacklist made sense. ...but for the Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's just not quite as full featured / efficient as the R8152 driver. Is that not a concern? I guess you could tell people in this situation that they simply need to enable the R8152 driver to get continued support for their Ethernet adapter? -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
