On Fri, Mar 20, 2009 at 06:46:42PM +0100, Daniel Mack wrote: > On Fri, Mar 20, 2009 at 10:27:58AM -0700, Greg KH wrote: > > > It is broken, yes. Without the patch, both the vendor name and the > > > product name are swallowed away in kernel space and lsusb. > > > > So it doesn't show up at all anymore? Do you have a specific example of > > this? > > It does show up, but with empty strings. These are admittedly our own > devices I got the problem with, but others might of course be equally > afected if they have a similar bug. Do these devices pass the usb.org certification tests? > > > a) Windows doesn't care > > > b) Mac OS X doesn't care > > > c) Linux used to not care, too. Don't know when that was changed, but it > > > must have been in the last months. So it's kind of a regression, even > > > tough the current behaviour is just currect in terms of the USB spec. > > > > Can you do a little bit of bisection of different kernel versions to > > figure out where this changed? > > Well, maybe I was wrong about that - I believed older kernels didn't > show that behaviour, but grepping thru the history tells me that I must > been mistaken. That very check is in the sources since a very long time. > > > > Anyway, with this patch applied, things work fine and I see no reason > > > why complaining with a warning shouldn't be enough. Failing so hard is > > > annoying. > > > > True. If you let me know when this broke, feel free to resend the patch > > with that information and I'll be glad to apply it. I need to know when > > it broke so that we can backport it to older -stable kernel versions if > > needed as well to make them work again. > > We should probably just queue that up as a fix for newer versions. It's > not really a breakage but more a cosmetic thing to see the strings, > right? Right. Care to resend it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
