On Thu, Mar 19, 2009 at 08:32:21PM -0700, Greg KH wrote: > On Tue, Mar 17, 2009 at 03:52:17PM +0100, Daniel Mack wrote: > > When an USB hardware does not provide a valid LANGID, fall back to value > > zero which is still a reasonable default for most devices. > > But that's a broken device, right? What happens without this patch? It is broken, yes. Without the patch, both the vendor name and the product name are swallowed away in kernel space and lsusb. > And has this device passed the usb.org test suite? Well, the thing is - this bug was always hidden from us because a) Windows doesn't care b) Mac OS X doesn't care c) Linux used to not care, too. Don't know when that was changed, but it must have been in the last months. So it's kind of a regression, even tough the current behaviour is just currect in terms of the USB spec. Anyway, with this patch applied, things work fine and I see no reason why complaining with a warning shouldn't be enough. Failing so hard is annoying. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
