Hi,
oliver@xxxxxxxxxx:
> It seems to me most of this belongs into the generic layer.
I agree.
> Also, using strings here really is arcane, as this will be parsed by
> software.
>
Both numbers and strings are magic, and the computational difference
between atoi() and strcmp() is negligible.
One comment about the implementation: Please use a table-driven
approach. We need that for some other enhancements that are planned for
the option driver anyway (for instance: URB sizes need to be adapted to
the device).
--
Matthias Urlichs | {M:U} IT Design @ m-u-it.de | smurf@xxxxxxxxxxxxxx
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
v4sw7$Yhw6+8ln7ma7u7L!wl7DUi2e6t3TMWb8HAGen6g3a4s6Mr1p-3/-6 hackerkey.com
- -
If the human brain were so simple that we could understand it,
we would be so simple we couldn't.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
